search

appsignal / appsignal-nodejs

🟩 AppSignal for Node.js
https://www.appsignal.com/nodejs/
MIT License
28 stars 9 forks source link

Remove the need for an Express error handler #1044

Closed luismiramirez closed 2 weeks ago

luismiramirez commented 4 months ago

The OpenTelemetry Express instrumentation now automatically records exceptions without the need of an error handler.

See: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1657

ToDo

unflxw commented 4 months ago

Going by the linked PR, it seems that it only records exceptions in middlewares? Does that cover our needs?

luismiramirez commented 2 weeks ago

That change doesn't cover our needs.

Here's an open issue reporting problems with the change: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2146

Internal link with the conversation: https://appsignal.slack.com/archives/C06TU59PXDF/p1714031628760559