Closed unflxw closed 4 months ago
:heavy_check_mark: All good!
I have tested that this works with the latest Yarn version (in that it removes the error reported by the customer during the AppSignal build, allowing the build to succeed with a reasonable looking install report and ext/
folder -- I have not tested further)
Hi @unflxw,
We've found new issues for this Pull Request. Please see the main comment on this issue for a list of all current warnings. This comment will not be updated to reflect resolved warnings.
[skip changeset]
to your Pull Request body. - (More info)This is a message from the daily scheduled checks.
@tombruijn I think you're right, I'll add a changeset of some sort, yes.
The thing is, I don't want us to proclaim in the docs again that we support Yarn or pnpm, though, like we used to do before this issue. Realistically, we're not doing proper testing with those tools.
But it would be nice to say we've made some improvements to the compatibility of our package with alternative package managers like Yarn or pnpm. Give them the same treatment we currently give to WSL: we don't explicitly support it, but if it works for you, that's great.
Declare the transitive dependencies that our code already imports as de facto dependencies in our
package.json
. Update thepackage-lock.json
accordingly.For
@opentelemetry/instrumentation
, which is only required for a type annotation, useimport type
instead.Fixes #1037. [skip changeset]