Support for NestJS - Githubissues

appsignal / appsignal-nodejs

🟩 AppSignal for Node.js

https://www.appsignal.com/nodejs/

MIT License

29 stars 9 forks source link

Support for NestJS #382

Closed thijsc closed 2 years ago

thijsc commented 3 years ago

Add support for NestJS.

https://nestjs.com/

To do

[x] Add instrumentation to the client by default https://github.com/appsignal/appsignal-nodejs/pull/769
- Only if the instrumentation library is part of the OpenTelemetry core or auto instrumentation package
[x] Add extractor for OpenTelemetry spans https://github.com/appsignal/appsignal-agent/pull/840
[x] Add integration test for spans https://github.com/appsignal/appsignal-nodejs/pull/769

Karman40 commented 3 years ago

Hi, any update for this?

tombruijn commented 2 years ago

No update yet. We're working on a bunch of other things for the Node.js integration at the moment.

shairyar commented 2 years ago

https://app.intercom.com/a/apps/yzor8gyw/inbox/inbox/4356044/conversations/16410700118344

MrTin commented 2 years ago

What's the status on this? I can't access the Intercom threads above so have no idea what they are about :) I've been using Appsignal extensively as a Rails dev but right now I'm working with NestJS, Prisma, and Apollo (GraphQL).

In its current state, it's not really that useful to my team so I might have to look for another solution. I really love Appsignal so would love to see official clients and/or guides to make it work.

We're missing out on some of the most useful features like Slow Queries and Event Timeline that drill down the method chains.

I got it integrated by following this article https://superface.ai/blog/nestjs-with-appsignal and then adapted it to work with Apollo.

shairyar commented 2 years ago

Hey @MrTin

We do support Apollo. Here are the docs on that: https://docs.appsignal.com/nodejs/integrations/apollo.html
At the moment, we are working on supporting open telemetry, through that we will be supporting nestjs. We intend to release that in version 3.0 but at the moment there is no timeline on its release. We will update this issue when we release that.
Prisma is not supported out of the box, so you need to implement custom instrumentation, few months back, I was helping another customer with instrumenting Prisma, you can have a look at this repo to get an idea on how to do the instrumentation.

luismiramirez commented 2 years ago

Instrumentation added to the 3.x beta (see linked PRs in description). Span extractors are in progress

unflxw commented 2 years ago

Hello, NestJS users! @MrTin @Karman40

We have just released a beta of the AppSignal for Node.js instrumentation that includes NestJS support. It also includes other niceties from previous betas, such as Prisma support.

To install it, follow the instructions on our installation guide. If you're already using AppSignal, this is a beta for the new major version of our AppSignal for Node.js integration, so there will be breaking changes. You should find the migration guide useful.

Let us know what you think! If you run into any issues, our support team will be happy to help, be it here, through the AppSignal application, or at support@appsignal.com.