appsignal / appsignal-nodejs

🟩 AppSignal for Node.js
https://www.appsignal.com/nodejs/
MIT License
29 stars 9 forks source link

AppSignal shows a scary-looking error on Windows #960

Open unflxw opened 9 months ago

unflxw commented 9 months ago

AppSignal should print an error message when on Windows, warning the user that AppSignal is not running -- but it should not look like it crashed. The error seen here about the install report, while not really a crash in itself, could be mistaken for one.

The error is also shown when AppSignal is not active -- in that case, loading the extension is not necessary, so we shouldn't show any error if active is set to false.

[appsignal][ERROR] Unable to fetch install report: Error: ENOENT: no such file or directory, open 'C:\[REDACTED]\node_modules\@appsignal\nodejs\ext\install.report'
at Object.openSync (node:fs:590:3)
at Object.readFileSync (node:fs:458:35)
at fetchInstalledArch (C:\[REDACTED]\node_modules\@appsignal\nodejs\dist\extension_wrapper.js:8:40)
at Object.<anonymous> (C:\[REDACTED]\node_modules\@appsignal\nodejs\dist\extension_wrapper.js:22:42)
at Module._compile (node:internal/modules/cjs/loader:1165:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
at Module.load (node:internal/modules/cjs/loader:1043:32)
at Function.Module._load (node:internal/modules/cjs/loader:878:12)
at Module.require (node:internal/modules/cjs/loader:1067:19)
at require (node:internal/modules/cjs/helpers:103:18) {
errno: -4058,
syscall: 'open',
code: 'ENOENT',
path: 'C:\\[REDACTED]\\node_modules\\@appsignal\\nodejs\\ext\\install.report'
}
[appsignal][ERROR] The AppSignal extension was installed for architecture 'unknown-unknown', but the current architecture is 'x64-win32'. Please reinstall the AppSignal package on the host the app is started.

Intercom conversation: https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/5246522/conversation/16410700272393#part_id=comment-16410700272393-21909540524

backlog-helper[bot] commented 9 months ago

:heavy_check_mark: All good!

New issue guide | Backlog management | Rules | Feedback

shairyar commented 6 months ago

https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/4356044/conversation/16410700286195 (private link)