Rename heartbeats to cron check-ins

appsignal / appsignal-python

🟦 AppSignal for Python package

https://www.appsignal.com/

MIT License

6 stars 2 forks source link

Rename heartbeats to cron check-ins #219

Closed unflxw closed 3 months ago

unflxw commented 4 months ago

In Ruby and Node.js, we use const_missing and Proxy respectively to make Heartbeat pretend to be Cron, allowing the result of instantiating one to pass an instance class check for the other and vice-versa, while also emitting a deprecation warning in the process.

Since the above is not possible in Python, we instead make a Heartbeat class that emits the deprecation warning, returns instances of Cron when initialised, and also pretends to be Cron when instance-checked against. It's not perfect (neither is Proxy) but it does the trick.

backlog-helper[bot] commented 3 months ago

This Pull Request has not had any activity in 14 days. Please provide a status update if it is still relevant. Closed it if it is no longer relevant. Or move it to another column if it's blocked or requires another look at it. - (More info)

This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

backlog-helper[bot] commented 3 months ago