The options were removed when we removed the request object from the Transaction in PR #1200. Clean up leftover from that refactor.
Remove public Transaction extension reader
Remove the reader for the Transaction extension from the public API (even if it's API doc is private) so no one can access it. Except for us in the test suite.
Rename Transaction duplicate method
Create a more Ruby-esque helper method duplicate? to query if the Transaction is a duplicate transaction or not.
Remove unused request reader from Transaction
The request was removed when we removed the request object from the Transaction in PR #1200. Clean up leftover from that refactor.
Remove paused attribute from Transaction
We already have a paused? helper for this. They return the same, no need for both.
Remove Transaction breadcrumbs attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
Remove Transaction tags attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
Remove Transaction error_blocks attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
Remove unused options reader from Transaction
The options were removed when we removed the request object from the Transaction in PR #1200. Clean up leftover from that refactor.
Remove public Transaction extension reader
Remove the reader for the Transaction extension from the public API (even if it's API doc is private) so no one can access it. Except for us in the test suite.
Rename Transaction duplicate method
Create a more Ruby-esque helper method
duplicate?to query if the Transaction is a duplicate transaction or not.Remove unused request reader from Transaction
The request was removed when we removed the request object from the Transaction in PR #1200. Clean up leftover from that refactor.
Remove paused attribute from Transaction
We already have a
paused?helper for this. They return the same, no need for both.Remove Transaction breadcrumbs attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
Remove Transaction tags attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
Remove Transaction error_blocks attr_reader
No need for this to be publicly accessible, even if the API doc for it says it's private.
We can still access it in the test suite.
[skip changeset] [skip review]