appsignal / mongo-rust-driver

Mongo Rust driver built on top of the Mongo C driver
Apache License 2.0
89 stars 22 forks source link

Problems with libicu #74

Open MightyPork opened 2 years ago

MightyPork commented 2 years ago

I upgraded to a newer version of the library to get support for mongodb 6.

However, it now needs libicu of a particular version, this is a problem for distribution as different linuxes have different icu version available.

I think this can be solved by adding ENABLE_ICU=OFF to the build script of mongoc-sys, i'm going to try making a local fork with that option added...

MightyPork commented 2 years ago

Okay so, this worked, probably MONGOC_ENABLE_ICU is enough, it seems to be stronger.

cmake.arg("-DMONGOC_ENABLE_ICU=OFF");
cmake.arg("-DENABLE_ICU=OFF");
thijsc commented 2 years ago

I had some trouble with this as well. Is there a disadvantage to turning this off?

MightyPork commented 2 years ago

I tried to find what it's used for, I believe it's only needed for usernames and passwords (and maybe collection names etc.) that use non-ASCII. For me that's not needed at all. I also got away with disabling ZSTD compression in the build so it's now a little smaller and more portable.