appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.64k stars 3.74k forks source link

[Feature]-[320]:Show error message on Table column name control #11194

Open aswathkk opened 2 years ago

aswathkk commented 2 years ago

Is there an existing issue for this?

Summary

If there are multiple columns in the table with the same name, the column name control shows a red border. But, it is not shown anywhere why the column name is red in color.

https://user-images.githubusercontent.com/10436935/154205000-16fc0e2c-7ce2-44ef-91d1-1d4677e22d22.mov

Why should this be worked on?

It is harder for the user to understand why the column name has a red border. The user has to figure out the relevance of the red border via trial and error. It would be great if Appsmith informs the user via debugger or via a popup why the border is turned red.

dilippitchika commented 2 years ago

@vasanth-appsmith @momcilo-appsmith this is a common problem with the list type input in the property pane.

It needs an improvement. My current suggestion is to show the error message on click, if we can't show it inline. Similar to other property pane errors like input fields.

We can have the evaluated value pop-up here as well which comes up only on error or a new type of error field.

momcilo-appsmith commented 2 years ago

@dilippitchika I think we already have error states for inputs in our DS, why are we not using those?

dilippitchika commented 2 years ago

@momcilo-appsmith can you leave a link to this in the DS, i'll take a look and move this

momcilo-appsmith commented 2 years ago

@dilippitchika https://www.figma.com/file/i80YbQLLs5mXthjIHclPpX/Appsmith-Design-System?node-id=4771%3A23181

Nikhil-Nandagopal commented 2 years ago

Assuming 10% of custom column users encounter this

Stats

Stat Values
Reach 160
Effort (months) 0.25