appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.77k stars 3.63k forks source link

[Feature]-[210]:Increase the filepicker supported size on cloud #11654

Open dilippitchika opened 2 years ago

dilippitchika commented 2 years ago

Is there an existing issue for this?

Summary

The 5mb limit is too less for our cloud users, we should increase this to at-least 30MB or beyond.

Why should this be worked on?

The size supported right now is too less and the alternative once some one has built an app is to then self host it and change the limit to support 100MB. A lot of work has to be done to simply self-host it only for this reason.

Gintasz commented 2 years ago

Increase the limit to 100MB. I have an admin panel where user can upload audio files. It's ridiculous the limit is 5MB for no reason. Why is this even an issue? The front-end should be connecting directly with the API (e.g. S3) to upload the file, without any proxying through the appsmith cloud servers.

dilippitchika commented 2 years ago

S3 issue for more than 5mb uploads - https://github.com/appsmithorg/appsmith/issues/11137

Nikhil-Nandagopal commented 2 years ago

@Gintasz this is an issue because all API calls must go through the server and processing 100mb files on a single server is a challenge when it is used by multiple users. Why it must never go directly from the frontend is because integrating with any data source requires authentication credentials and those being on the frontend is a serious security risk. This is why we ask users to move to self hosted if they need this since their servers will be under lesser load than our shared Appsmith cloud. How we plan on solving this correctly is by implementing file streaming to upload large files as chunks of data

Gintasz commented 2 years ago

@Gintasz this is an issue because all API calls must go through the server and processing 100mb files on a single server is a challenge when it is used by multiple users. Why it must never go directly from the frontend is because integrating with any data source requires authentication credentials and those being on the frontend is a serious security risk. This is why we ask users to move to self hosted if they need this since their servers will be under lesser load than our shared Appsmith cloud. How we plan on solving this correctly is by implementing file streaming to upload large files as chunks of data

please make it optional to allow it to go to the API directly. If it's a small-scale admin panel and end-user is 1 person, or just a few people, who are added through the "invite user" system, thus trusted by the developer, it can be assumed that there is no serious security risk. Then it won't need to go through your servers and problem will be solved easily and quickly.

While self-hosting is an alternative solution, it's not very viable if the admin-panel is intended to be opened by 1 user (system owner) maybe 2 times every 3 months, or similar...

mojtab23 commented 2 years ago

Related issue #11711 for UI/UX improvement.

rohan-arthur commented 2 years ago

stats copied from #11137

rohan-arthur commented 2 years ago

Stats

Stat Values
Reach 105
Effort (months) 1