search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.64k stars 3.74k forks source link

[Feature]: Improve the URL for git connected apps by removing branch=master as query parameter #13955

Open mohanarpit opened 2 years ago

mohanarpit commented 2 years ago

Is there an existing issue for this?

Summary

In an effort to have cleaner URLs, we should remove the query parameter ?branch=master as the default query parameter as the default shareable URL. Only if the user is sharing the app via another branch should this query parameter be present. In the default branch, the query parameter should be omitted and be derived.

Why should this be worked on?

Having clean URLs makes sharing Appsmith URLs easier for users. Also, for deployed applications, the branch parameter doesn't make sense for the app viewer. Hence, by default, the branch query parameter should be omitted.

hiteshjoshi commented 2 years ago

@abhvsn @IAmAnubhavSaini can we pick this up as sub part of [EPIC] Git performance & UX #13823 I will attach this on zenhub.

hiteshjoshi commented 2 years ago

Abhijeet : This can break the apps for some users who are relying on query parameter for branch for certain actions.

Nikhil-Nandagopal commented 1 year ago

This should just be tied to RBAC and devs should be able to restrict the branches that a user has access to. @riteshkew