appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.7k stars 3.75k forks source link

[Bug]-[5000]:async tag not assigned in absence of null checks #14229

Closed eco-monk closed 1 year ago

eco-monk commented 2 years ago

Is there an existing issue for this?

Description

Missing null checks in Js objects result in async tag not getting assigned to a function.

This is because, we do a dry run of the method and it throws Cannot read properties of undefined. Before the execution reaches the async part of the code.

Steps To Reproduce

export default {
    myVar: [],
    myVar2: {},
    myFun1: () => {  
        //this.myVar[0].id;
        //this.myVar2.data.id;
        return Api1.run()
    },
}

https://www.loom.com/share/459c8b3ad1f14f73a712fcaf1bedf77a

Possible Solution

Check - https://github.com/appsmithorg/appsmith/issues/14618#issue-1274629024

Public Sample App

No response

Version

Cloud - Appsmith v1.6.26-SNAPSHOT

rohan-arthur commented 2 years ago

6m usage of js object: 2500 consider 50% of users run into this, 1250

Stats

Stat Values
Reach      1250
Effort (months)  <>
ayushpahwa commented 2 years ago

6m usage of js object: 2500 consider 50% of users run into this, 1250

Stats

Stat Values
Reach      1250
Effort (months)  0.25
ApekshaBhosale commented 2 years ago

same as https://github.com/appsmithorg/appsmith/issues/14229