search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
32.47k stars 3.52k forks source link

[Bug]: Dynamic height issues observed in Radio group widget on DP #15354

Closed btsgh closed 1 year ago

btsgh commented 1 year ago

Is there an existing issue for this?

SubTasks

DP observed on - https://appsmith-git-poc-dynamic-height-range-slider-get-appsmith.vercel.app/

AUTOHEIGHT

  1. Drag and drop the radio group widget and change the selection to Auto Height from the Height dropdown. Note that the height does not change.

    RadioGroup_FixedtoAuto_Nochange

  2. This is noted even on adding many options and then deleting the options.

    RadioGroupManytoDelete_NoChange

  3. On setting the height to Auto Height, and the label positioning to Top, as we keep adding to the label text, the auto height does not function correctly. There is an overlap of border with text seen

    RadioGroup_Label_Top_LongLabelAutoHeight

  4. With the label position set at AUTO, increase the label text size from S to M, L, XL, XXL, 3XL and observe that the height has issues when XL and 3XL are chosen.

    RadioGrpWidget_LabelAuto_Textsizeincreased

AUTO HEIGHT WITH LIMITS

  1. Drag and drop a Radio group widget, widen it a little, and set Auto Height with Limits - min - 5rows max - 22 rows . Keep adding options and as number of options just goes beyond the border, there is an overlap, instead of a scroll getting added.

    Screenshot 2022-07-21 at 4 59 07 PM

  2. If the widget is to the right side of the canvas, the min and max height limits indicators text seems like it is cut off (this is true of any widget)

    Screenshot 2022-07-22 at 10 46 46 AM

  3. Drag and drop a Radio group widget. Just below the Radio group widget, add a Select or any other widget say rating. Now enable Auto height with limits and set some min and max limits for the radio group widget. We see that as the pink area encloses the widget below it as well. Ideally, as the max height is set, it should push the widget below it further down beyond the max height limit.

    RadioGroup_AutoHeightWithLimits_Widgetbelow
github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

github-actions[bot] commented 1 year ago

We have found issues that are potential duplicates:

ankurrsinghal commented 1 year ago

@btsgh Is it fixed earlier? I am not able to see the same problems in the new DP, you can check it here https://github.com/appsmithorg/appsmith/pull/16268

Sripriya93 commented 1 year ago

AUTO HEIGHT Scenario 1 - Working fine Scenario 2 - Working fine with added options Scenario 3 - Working fine with Top position, and added more words Scenario 4 - Working fine when we change size from S to 3XL

AUTO HEIGHT WITH LIMITS Scenario 1 - Working fine image Scenario 2 - Working fine image image Scenario 3 - Working fine image