search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.77k stars 3.63k forks source link

[Bug]: Search bar returns results even when "Enable client side search" is disabled #15386

Open shadabbuchh opened 2 years ago

shadabbuchh commented 2 years ago

Is there an existing issue for this?

Description

In Table v2 when we disable the Enable client side search property and then enter some text in the Search bar, the search returns results.

https://www.loom.com/share/9c5527a7a6b6426d8d999a7ee697a1c4

Steps To Reproduce

  1. D&D a Table widget.
  2. Bind it with an API/Query.
  3. Disable the Enable client side search property.
  4. Now enter any text in the Search bar.

Expected: The search should not filter out data. Actual: Upon entering any text in the search bar, it returns results based on the search.

Public Sample App

No response

Version

Cloud

sbalaji1192 commented 2 years ago

@dilippitchika @shadabbuchh This is a known behavior in Table v1 as well. When you disable enable client side search and don't have any binding in onSearchTextChanged property, we still go ahead and do client-side search. should we keep doing that or strictly follow the enable client side search property?

dilippitchika commented 2 years ago

No, we should not search on client side, when this switch is turned off. This will be a bigger change. Keeping this open.

Naveen-Goud commented 2 weeks ago

Hii @carinanfonseca @shadabbuchh trying to reproduce this issue.