search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.23k stars 3.6k forks source link

[Feature]: Frontend Validation checks for datasource configurations #17341

Open sneha122 opened 1 year ago

sneha122 commented 1 year ago

Is there an existing issue for this?

Description

While looking into issue #12750 I checked out frontend validations for all datasources and it seems that we have frontend validations added only for elastic search DS. I am listing out the all datasources where we might require same validation as elastic search. @rohan-arthur @sumitsum please confirm if we need validations at these places or not.

  1. Arango DB

    • [ ] Host Address [URL Validation]

  2. Dynamo DB

    • [ ] AWS Access key ID [Required Validation]

  3. Firestore

    • [ ] Database URL [URL Validation]

  4. MSSQL

    • [ ] Host Address [URL Validation]

  5. Redis

    • [ ] Host Address [URL Validation]

  6. Redshift

    • [ ] Host Address [URL Validation]

  7. S3

    • [ ] Access Key [Required Validation]
    • [ ] Secret Key [Required Validation]

  8. SMTP

    • [ ] Host Address [URL Validation]

  9. Postgres

    • [ ] Host Address [URL Validation]

Steps To Reproduce

  1. Go to Datasources
  2. Create New Datasource
  3. Create any datasource and checkout the required fields/ host address field

Public Sample App

No response

Version

Cloud/ Self-Hosted - 1.8.4

rohan-arthur commented 1 year ago

this should be included in project https://www.notion.so/appsmith/5e2b06deac7a490e837ce0d4a69db684?v=79f5fafba6564d3a81540062e8339c3a&p=97cf677a43cb455c82d5c37191591ada&pm=s

daaliachhak17 commented 1 month ago

created ticket on Jira- https://zemoso.atlassian.net/browse/TNOSB-389

saicharan-zemoso commented 1 month ago

Hello @sneha122 , @rohan-arthur , can try and work on this issue??