[Bug]: Events/action fields are not consistently placed on the property pane

ramsaptami commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Event/actions fields are not consistently placed on the property pane leading to confusion to both existing and new users. Some of them are placed under Events heading and the others are place under other related fields as seen in the screenshots attached.

Steps To Reproduce

Examples:

Trigger fields under Events

Trigger fields not under Events

Public Sample App

No response

Issue video log

No response

Version

Cloud

dilippitchika commented 1 year ago

@ramsaptami this is intentional because if an event is linked to some other properties users were finding it hard to discover what to do next for example onRowSelected event will only make sense if the user is enabling row selection.

Has a user raised this issue of not being able to discover something?

https://www.notion.so/appsmith/Property-Pane-tabs-rules-properties-etc-b60821925884420f85f198e648f91b38 This is the philosophy behind the grouping and we intend to keep it that way to ensure more people don't miss out events when they are configuring specific flows.

ramsaptami commented 1 year ago

Hey @dilippitchika, the logic behind the new grouping, albeit noble, isn't well communicated. Let me explain what I experienced and consequently saw other QA members point out in a group session.

When I first saw the new grouping on the table widget, the reshuffle made sense since related trigger fields followed the fields I was editing
Then I opened up property pane for select, radio (..etc..) and saw this was not the case, I expected onOptionChange to follow options cause they're related but it was tucked under Events here
We also have map widget where it's trigger onMarkerSelect is not under it's corresponding setting which made me believe this was still a WIP project - not one where a select few were considered for categorization
From an old user perspective, seeing the reshuffle made me believe this is a global change, and expected other widgets to follow suit in subsequent iterations, from a new user perspective - it feels buggy.

It was only after speaking to Aswath asking for ETA on completion did I find out the project is already completed - hence raised an issue for the ambiguity it caused.

Edit: users were internal QA team :)

appsmithorg / appsmith