appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.79k stars 3.64k forks source link

[Feature]: Separate label for Canada Country Code on Phone Input Fields #18136

Open jdglacier opened 1 year ago

jdglacier commented 1 year ago

Is there an existing issue for this?

Summary

On the Phone Input Widget, add a separate country code to the drop-down list for Canada to ensure the label is properly displayed on forms.

image

Why should this be worked on?

Even though Canada and the United States share the same country code, the label is displayed as 'US'. Adding a separate option for Canadian phone numbers would help avoid confusion for Canadian users of Appsmith.

somangshu commented 1 year ago

@vsvamsi1 have we figured what is going to be our approach here?

vsvamsi1 commented 1 year ago

Yeah @somangshu i have, will be using the countryCode instead of the ISD code. Canada and USA share the same ISD code, so its difficult to distinguish between both. Hence using the countryCode.

dilippitchika commented 1 year ago

Hey i didn't understand the approach, can you explain what the difference is between country and isd code?

dilippitchika commented 1 year ago

Discussed with @vsvamsi1

This looks like a bigger effort, we will come back to this later. CC @somangshu