[Bug]: Widget looses theme properties and appears grey when renamed as a number.

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

33.9k stars 3.66k forks source link

[Bug]: Widget looses theme properties and appears grey when renamed as a number. #19217

Open shwetha-ramesh opened 1 year ago

shwetha-ramesh commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

When a user renames a widget to a numeric, the widget looses its theme properties and appears grey.

Steps To Reproduce

Drag and drop any widget (Table/Button/buttongroup)
Change the widget to a number and observe

Public Sample App

No response

Issue video log

https://loom.com/share/deab7a97dae9445e9a64304b28bc029c

Version

Cloud

ramsaptami commented 6 months ago

Issue is present on WDS and can be observed on a table widget

daaliachhak17 commented 2 months ago

ticket created on Jira -https://zemoso.atlassian.net/browse/TNOSB-347

saicharan-zemoso commented 2 months ago

Hello @Nikhil-Nandagopal , This bug will be resolved with this PR: https://github.com/appsmithorg/appsmith/pull/34963

As suggested In the issue: https://github.com/appsmithorg/appsmith/issues/22259

we won't let users name the widget with a name which starts with a digit or a number it self.

Nikhil-Nandagopal commented 1 month ago

@saicharan-zemoso can you ensure this happens not just for widgets but for queries and JS objects as well?

saicharan-zemoso commented 1 month ago

Hello @Nikhil-Nandagopal , The validations are already available for js object naming and for the queries it was only missing for widgets and that was added: for js objects:

for queries: