appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.65k stars 3.74k forks source link

[Bug]: Google OAuth 2.0 cannot re-authorize #19933

Closed onomou closed 1 year ago

onomou commented 1 year ago

Is there an existing issue for this?

Description

In Edit Datasource, I try to click Save and Re-Authorize, but the button is disabled.

Steps To Reproduce

I added a datasource for Google Classroom, using Google OAuth 2.0 granting an authorization token. When I save and re-authorize, it works as expected. However, if I wait a few days, it appears that the authorization expires and I need to re-authorize. A few weeks ago I could go into Edit Datasource, scroll to the bottom, and click Save and Re-Authorize. When I tried today, the button is disabled unless a change is made to the configuration.

Public Sample App

No response

Issue video log

No response

Version

Cloud

sneha122 commented 1 year ago

During datasource autosave, we had decided to disable the save button if there are no new changes in the datasource form, this issue came up due to that change. For some users who have already created Auth API Datasource, if they just want to re-authorise the datasource, they have to make some change and enable the button. To solve this issue, as discussed with @rohan-arthur, we would keep this button enabled all the times, so that user can go ahead and authorise the datasource, without making any new changes. This will unblock the users for now, but we would tackling this issue in depth with datasource validity project CC: @rohan-arthur @sumitsum

prapullac commented 1 year ago

Completed testing on the local and works well