search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.77k stars 3.63k forks source link

[Bug]: Unable to upload binary files to S3 #20315

Closed nidhi-nair closed 2 months ago

nidhi-nair commented 1 year ago

Is there an existing issue for this?

Description

Although the base64 option works for S3, the binary option results in corrupted data in S3. The upload does succeed with the correct size and type, this might be a case of unexpected encoding formats.

Steps To Reproduce

  1. Drop a filepicker widget and edit its properties to store binary data
  2. Add a new S3 query to create a new file
  3. Choose Text / Binary option for this query
  4. Try to upload a PDF file to S3

Public Sample App

No response

Issue video log

https://user-images.githubusercontent.com/5298848/216295545-993d62c2-61cf-497b-9686-5bf04d54c91d.mov

Version

Cloud

marcokiewit commented 1 year ago

I had the same problem when uploading via post request.

felix-appsmith commented 1 year ago

This problem also affects the file upload to other APIs like Drive. This user reported it: https://app.frontapp.com/open/cnv_11do02bw?key=nOrL1kbM8-zURYl1tdYkhdU0cqbswQM0

ankitgehlot123 commented 2 months ago

i am facing the same issue while uploading a zip file to S3 bucket using binary option in File Picker and S3 Query. In addition to file corruption, file size increased from 18 mb to 23 mb

rohan-arthur commented 2 months ago

this works now, we recently shipped a fix but didn't get around to closing this issue.

https://github.com/appsmithorg/appsmith/assets/94514895/1a44c823-daf8-4afd-91bc-9215106c853c