appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.52k stars 3.62k forks source link

[Task]: Perf - Remove diffing post eval #20684

Closed ApekshaBhosale closed 2 weeks ago

ApekshaBhosale commented 1 year ago

Is there an existing issue for this?

SubTasks

Reason - During the post-eval operation, we take diff between the previously evaluated tree and the currently evaluated tree to apply those changes to redux(evaluate tree). check the below code line - https://github.com/appsmithorg/appsmith/blob/713ca6ffc4f84322b8526b66eedd63269fa0cae3/app/client/src/sagas/EvaluationsSaga.ts#L190 Related coneration - https://theappsmith.slack.com/archives/C04PL6T2V5J/p1676444268084839?thread_ts=1676385703.109499&cid=C04PL6T2V5J

Suggested solution - Let's not take diff at all. As we have evaluationOrder already and using this let's track paths with it's evaluated values to directly apply changes

satbir121 commented 1 year ago

@ApekshaBhosale is looking into this issue and figuring out solutions.

bharath31 commented 1 year ago

@ApekshaBhosale could you please confirm if this still needs to be worked on?

bharath31 commented 12 months ago

@satbir121 please share the next steps here

rohan-arthur commented 2 weeks ago

same as #31847