appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.96k stars 3.66k forks source link

[Bug]: Duplicate tab names allowed in Tab widget #25024

Open shwetha-ramesh opened 1 year ago

shwetha-ramesh commented 1 year ago

Is there an existing issue for this?

Description

Same tab name can be renamed to multiple tabs in the same widget image image

Old issue which was raised and fixed : 11017

Expected result : Duplicate tab names must not be allowed. Also if a error string can be displayed instead of just having red highlight on the property pane

Steps To Reproduce

  1. Drag and drop Tab widget
  2. Rename more than 2 tabs with the same name

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud

somangshu commented 1 year ago

@momcilo-appsmith what do you think we should do additionally.

also, @shwetha-ramesh do you have any expected behaviour?

momcilo-appsmith commented 1 year ago

Can someone explain why should it not be allowed?

shwetha-ramesh commented 1 year ago

@somangshu @momcilo-appsmith Same issue was raised sometime back and it was fixed to make the behavior similar to Table widget.

somangshu commented 1 year ago

@momcilo-appsmith one reason from the top of my head is that it will be difficult to select default tab predictably if the values are not unique