Open ame-appsmith opened 1 year ago
@keyurparalkar please triage this, i assume this is happening because options is an array of arrays.
@dilippitchika irrespective of whether its array of arrays or not, we will still see this bug. I have triaged this and found out that the validation are working fine but the way we return the error message is incorrect inside the selectedOptions
property's validation function.
Today we return the error message in the form of array of string, but the platform APIs expect the error message to be in the following format:
[
{
name: "<Error-type>",
message: "Error message string"
}
]
Solution: Update the validation function for this property to return the error message in the above format
@keyurparalkar is this is problem in general. We might also need an RCA from a relevant team if this is miss in information flow. I.E. if the change was made without the dependency been taken care of, its a problem! On the contrary, could it be something we could have done better? 🤔
I think error handling change was handled in this PR but I think table widget was not included in the PR. @ChandanBalajiBP can you confirm?
@somangshu @ChandanBalajiBP has confirmed that this was missed out in the above PR.
@keyurparalkar @ChandanBalajiBP what are the next steps here?
Is there an existing issue for this?
Description
In a Table widget, when the user sets the Column type of a column to Select, then enters an incorrect value for Options (e.g., if there's a syntax error or duplicate values), an empty irrelevant error is displayed in both the Errors tab and the Options property, which is not helpful for debugging the issue.
We need to display a relevant error message to help users debug such kind of issues.
Steps To Reproduce
Public Sample App
https://app.appsmith.com/app/table-select-column-error/page1-64c4245e5ebbd221b60b42f1
Environment
Production
Issue video log
No response
Version
Appsmith v1.9.29