Improve eslint rules for packages - Githubissues

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

34.02k stars 3.67k forks source link

Improve eslint rules for packages #27621

Open KelvinOm opened 1 year ago

KelvinOm commented 1 year ago

Analyse rule sets from standardJs and airbnb.
Make a report.
Apply rules to packages.
Fix errors in packages

[x] @typescript-eslint/strict-boolean-expressions
[x] @typescript-eslint/promise-function-async
[x] @typescript-eslint/prefer-nullish-coalescing
[x] @typescript-eslint/consistent-type-definitions
[ ] react-hooks/exhaustive-deps
[ ] @typescript-eslint/array-type
[ ] @typescript-eslint/prefer-optional-chain
[ ] @typescript-eslint/consistent-type-assertions
[ ] @typescript-eslint/no-unnecessary-type-assertion
[ ] @typescript-eslint/prefer-includes
[ ] @typescript-eslint/no-floating-promises
[ ] @typescript-eslint/no-dynamic-delete
[ ] @typescript-eslint/method-signature-style

KelvinOm commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @dhruvikn @ichik @jsartisan @KelvinOm