search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.93k stars 3.66k forks source link

[Feature] Users would like to enable optional encoding of URI for APIs #2897

Closed nidhi-nair closed 3 years ago

nidhi-nair commented 3 years ago

A default true option for encoding allows users to skip a forced decoding step in case their URI components are already encoded.

nidhi-nair commented 3 years ago

Additional context: The gap was felt against a developer experience with tools like Postman that allow complete configuration for the API. REF

sumitsum commented 3 years ago

Re-opening this issue because UI change is pending. @Nikhil-Nandagopal - assigning it to you so that it can be re-assigned.

Nikhil-Nandagopal commented 3 years ago

@sumitsum I think settings UI is config driven from backend. @mohanarpit isn't that so?

sumitsum commented 3 years ago

@Nikhil-Nandagopal @mohanarpit

I was able to find a form.json file that maps values to datasourceConfiguration object but couldn't see any such .json file to map values to actionConfiguration. Also, I am not sure if a toggle kind of UI element is supported via .json file - I can try to add a dropdown with Enable/disable option and map to datasourceConfiguration if that is okay.

mohanarpit commented 3 years ago

@Nikhil-Nandagopal @sumitsum The action settings are driven by the backend config JSON only for the query pane, not API pane.

The API pane is still a custom React component and the settings are driven by this file. We need to add a setting in the JSON here and also handle that setting when the action is saved.

sumitsum commented 3 years ago

@Nikhil-Nandagopal need your opinion here.

mohanarpit commented 3 years ago

@ofpiyush Assigning this to you. Is it possible for you to add this to the API settings page quickly? We'll be able to close this feature then.

ofpiyush commented 3 years ago

We should run a migration to set this to true on existing actions + configure new action creation to set this to true so that UI doesn't look wrong.

Right now, it will look unchecked by default, but be on.