[Bug]: Afterr changing the Authentication Type to Basic, Api Key or Bearer token, Saving does not retain the selections in the following example

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

34.5k stars 3.72k forks source link

[Bug]: Afterr changing the Authentication Type to Basic, Api Key or Bearer token, Saving does not retain the selections in the following example #30070

Open btsgh opened 10 months ago

btsgh commented 10 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Description

When I create a new Auth api or save a Rest API as a datasource, on changing the Authentication Type to Basic, Api Key or Bearer token, Saving does not retain the selections if we do not enter anything in the respective username_pwrd/key_value/token fields

Steps To Reproduce

https://github.com/appsmithorg/appsmith/assets/101863839/21c8daa0-a302-4c16-94a4-a5232e181c85

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud

rohan-arthur commented 7 months ago

@btsgh thanks for reporting this. In my opinion, it is good that auth type gets reset to None if the required fields are not entered. Would it be better if we had validation to disallow save when the required fields are not entered?

btsgh commented 7 months ago

@btsgh thanks for reporting this. In my opinion, it is good that auth type gets reset to None if the required fields are not entered. Would it be better if we had validation to disallow save when the required fields are not entered?

Yes @rohan-arthur - in that case, lets make the fields mandatory - and disallow save if those are not entered. At present it is giving a feeling that it is getting saved, but data is not saved actually.

dev-madhurendra commented 1 day ago

Hi @btsgh @rohan-arthur ,

Would you like me to take on this bug?