appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
32.3k stars 3.5k forks source link

[Bug]: IFrame widget doesn't refresh when changing the link in some scenario #30525

Open LagunaElectric opened 5 months ago

LagunaElectric commented 5 months ago

Is there an existing issue for this?

Description

When I change the URL of an IFrame widget it loads the first time, but changing the URL doesn't refresh the IFrame after that.

This is not a consistent behavior. I'm able to get the IFrame to work as intended when switching between a list of arbitrary Wiki articles, but the issue can be reproduced with the below set of links:


[
    {
        "url": "https://www.sellebrate.io/#/chats/936ae895-b4f4-4d43-98c9-49781e5996e8"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/9f7a6218-42f1-4de0-bf12-adf4bea9bcd0"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/fef2c357-ea51-4c11-ae96-0c1781af9760"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/00caf477-67ed-4093-aefd-aaf3a00b9718"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/95788261-7de9-453f-a234-da6e9b4ecf68"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/609825b9-c049-4934-ba4e-5ba569de9675"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/9dddf95e-e0f8-4848-a186-5fe1d291ab3d"
    },
    {
        "url": "https://www.sellebrate.io/#/chats/3b8a6ae9-2a74-4924-aa2d-1de6fdbd7339"
    }
]

Steps To Reproduce

  1. Visit the linked sample app.
  2. Click through the items in the list to change the source URL of the IFrame.
  3. Observe that each Wiki article is loaded when you click the items.
  4. Confirm that the IFrames source URL is being updated with the text widget underneath it.
  5. Use the select widget to switch to the users provided dataset.
  6. Click one item and observe that the IFrame loads the chat.
  7. Click another item and observe that the displayed page does not change.
  8. Confirm that the source URL is changing with the text widget under the IFrame.

Public Sample App

https://app.appsmith.com/app/iframe-not-refreshing/example-65af0641410d613b430c8dd8

Environment

Production

Issue video log

No response

Version

Cloud v1.10.0-SNAPSHOT

baarrull commented 5 months ago

Hey! :) Any update on this?

LagunaElectric commented 4 months ago

@kamakshibhat-appsmith @somangshu This user is reaching out again about this issue. Do we have any updates for @baarrull?

Nikhil-Nandagopal commented 4 months ago

@baarrull @LagunaElectric I believe the issue is because the links change after a # in the link which is generally used for anchor tags and therefore does not trigger a refresh. We don't plan on fixing this anytime soon. If it's possible on your end, you could update the URLs to not include the #.