[Task]: Move expires_in field after scope while configuring oauth2 datasource

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

34.6k stars 3.73k forks source link

[Task]: Move expires_in field after scope while configuring oauth2 datasource #31059

Open sneha122 opened 9 months ago

sneha122 commented 9 months ago

SubTasks

When creating authenticated API datasource for OAuth2, shift expires_in input field just after scope, so that all authentication fields are adjacent to each other, and users can discover it quickly Screenshot 2024-02-12 at 3 38 29 PM

yasharma2301 commented 9 months ago

If this issue has to be worked on, I can take it up

bandhan-majumder commented 8 months ago

@sneha122 @Nikhil-Nandagopal Hi. I want to ask if this is a rendered HTML page or something else. It may sound stupid, but it's my first time contributing.

theAravinthM commented 8 months ago

Hi @sneha122 I'm interested to start off my contribution through this issue. I need one clarification. Is shifting _expiresin field alone is okay OR all 2 following fields ( Audience & Resource ) also need to be shifted ?

sneha122 commented 8 months ago

Hi @yasharma2301 This is a good first issue, you can take it up if you want, Apologies for the delayed response!!

sneha122 commented 8 months ago

Hi @theAravinthM We just need to shift expires_in field after the scope, no need to shift other fields, they can remain as they are today, Hope this helps!

sneha122 commented 8 months ago

Hi @bandhan-majumder The code for this is written in JSX, which is eventually translated to HTML internally by React framework, Hope this answer helps!!

theAravinthM commented 8 months ago

Hi @sneha122 ! Just made a PR - #31863 . Could you please review!

subhajit20 commented 7 months ago

hey @sneha122 is this issue resolved or anyone is already working on it?

sneha122 commented 7 months ago

@subhajit20 Yes there are already PRs created for this

BOSE-git commented 3 months ago

Hello, is this issue still open?

sneha122 commented 3 months ago

Hi @BOSE-git There were PRs created for this issue earlier but due to various issues, we could not get around to merging these PRs. Let us discuss this internally and prioritise.

BOSE-git commented 3 months ago

Should I connect on LinkedIn?

BOSE-git commented 3 months ago

If there is any issue that I can help with, I will be happy to contribute

NilanshBansal commented 3 months ago

Moving this to Product Backlog as no response from the contributor

dakshmehta007 commented 2 months ago

@sneha122 but there is not any expires_in section available in form file. Are we have to create that by ourself ?