search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
32.44k stars 3.51k forks source link

[Bug]: Deleting jslib gives incorrect status in modal #32734

Open btsgh opened 3 months ago

btsgh commented 3 months ago

Is there an existing issue for this?

Description

Deleting a jslib does not give a message to the effect that the jslib is deleted. It only says Application Settings modified.

Steps To Reproduce

https://github.com/appsmithorg/appsmith/assets/101863839/a44c43af-73c3-4a1a-9732-40bb2abe0a7e

Public Sample App

No response

Environment

Release

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Cloud

brayn003 commented 2 months ago

Just tested this - Reproduction of this issue is not just related to deleting the jslib. Here are some additional scenarios -

  1. Add a jslib and commit > remove jslib > status for jslib doesn't show up > add a jslib > now both jslib changes show
  2. Add uzip-module jslib and commit > remove uzip-module > jslib status changes showup > add jsonwebtoken > no jslib status change show up
  3. Add jsonwebtoken jslib and commit > remove jsonwebtoken > jslib status changes don't showup

The best way I can describe this - Jslibs is acting funny with git

Nikhil-Nandagopal commented 1 month ago

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed