search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.33k stars 3.72k forks source link

[Bug]: SSH URL pattern for private repo check does not accommodate custom port in the check #32862

Open nidhi-nair opened 6 months ago

nidhi-nair commented 6 months ago

Is there an existing issue for this?

Description

The current pattern makes it so that the port is included as part of the path of the URL where the private repo check is made

Steps To Reproduce

Connect to a git repo on a custom port and debug through private repo check

Public Sample App

No response

Environment

Production

Severity

Low (Inconsistent UI/UX)

Issue video log

No response

Version

Cloud

infinitetrooper commented 3 months ago

@brayn003 - didn't we close this?

Sai6347 commented 2 weeks ago

Hi @nidhi-nair, Could you please provide additional details regarding how the private repo check should ideally handle the custom port?

shanid544 commented 1 week ago

Hi @nidhi-nair When users attempt to connect to a GitHub private repository using a custom port, and the connection fails due to a timeout error. and in the UI we are not getting ant error message.

The URL format I provided (ssh://git@github.com:2222/shanid544/appsmith-app.git) is valid for SSH connections, but GitHub typically uses port 22 for SSH. Custom ports like 2222 may not be accepted by GitHub, leading to connection timeouts.

Currently, when a timeout occurs, users are not receiving any feedback or error messages in the UI, which can lead to confusion.

What fix we need to do on this? Should we show proper error message in the UI. or anything else, Please confirm