Closed rishabhrathod01 closed 1 week ago
[!WARNING]
Rate Limit Exceeded
@rishabhrathod01 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 48 minutes and 1 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 7c0b171e160d04acd9880f4ff5e6317a7e502495 and 9a7fc9cc1942ddc61c54f6ae9451706ad527f49c.
The recent changes aim to enhance security by masking API keys in logs. This involves updating methods in several classes to handle DatasourceConfiguration
and mask sensitive information in query parameters and headers. Additionally, new tests were added to ensure the correct masking of API keys.
File Path | Change Summary |
---|---|
.../RequestCaptureFilter.java |
Added imports, a method to mask query parameters, updated URI creation logic, and adjusted header processing. |
.../RestAPIActivateUtils.java |
Updated triggerApiCall method to accept and utilize DatasourceConfiguration . |
.../GraphQLPlugin.java |
Modified executeCommon method to accept and pass DatasourceConfiguration . |
.../RestApiPlugin.java |
Updated executeCommon method to handle DatasourceConfiguration . |
.../RestApiPluginTest.java |
Added tests for masking API keys in query parameters and headers. |
Objective | Addressed | Explanation |
---|---|---|
Mask API keys in logs for datasources using API key authentication (#30009) | ✅ | |
Ensure new method createURIWithMaskedQueryParam correctly masks sensitive data in URIs (#30009) |
✅ | |
Update relevant methods to handle DatasourceConfiguration and mask sensitive headers (#30009) |
✅ | |
Add tests to verify masking functionality for API keys in query parameters and headers (#30009) | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
/build-deploy-preview skip-tests=true
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9203592447.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: true
.
env: ``.
PR: 33528.
recreate: .
Deploy-Preview-URL: https://ce-33528.dp.appsmith.com
Description
Fixes #30009
Summary:
This PR addresses the issue of masking sensitive information in query parameters or headers based on the authentication type selected by the user. The changes ensure that sensitive data is properly masked before sending back as response.
Changes:
Testing:
Verified that the masking functionality works as expected for API_KEY authentication types.
Automation
/test datasource
:mag: Cypress test results
Communication
Should the DevRel and Marketing teams inform users about this change?