search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
31.96k stars 3.44k forks source link

chore: allow deleting toolbar + add icon for toolbar creation #33544

Closed jsartisan closed 2 weeks ago

jsartisan commented 2 weeks ago

Fixes: #33395

/ok-to-test tags="@tag.Anvil"

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9127232599 Commit: 70759b80893d1c014ca305020f1a9e429267de2c Cypress dashboard url: Click here!

coderabbitai[bot] commented 2 weeks ago
Walkthrough ## Walkthrough The changes primarily focus on enhancing the functionality and user experience of toolbar buttons in the application. Key updates include always showing the delete button in the draggable list, introducing a new `ToolbarButtonListControl` class with methods to add options and define control type, and updating the control type in the property pane configuration to support toolbar buttons. ## Changes | Files/Paths | Change Summary | |-----------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------| | `app/client/src/components/propertyControls/DraggableListCard.tsx` | Simplified the conditional rendering logic to always show the delete button. | | `app/client/src/components/propertyControls/ToolbarButtonListControl.tsx` | Introduced `ToolbarButtonListControl` class with methods to add options and define control type. | | `app/client/src/components/propertyControls/index.ts` | Added `ToolbarButtonListControl` to the `PropertyControls` exports. | | `app/client/src/widgets/wds/WDSToolbarButtonsWidget/config/propertyPaneConfig/contentConfig.ts` | Updated `controlType` from "GROUP_BUTTONS" to "TOOLBAR_BUTTONS" in the property pane configuration. | ## Assessment against linked issues | Objective (Issue #33395) | Addressed | Explanation | |----------------------------------------------------|-----------|-----------------------------------------------------------------------------| | Add a default thumbup icon for a new button | ❓ | The provided summary does not mention adding a default thumbup icon. | | Add the ability to remove separators | ✅ | |
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 3e06f1a5704d1303328751b0093663c14330d8ce and 70759b80893d1c014ca305020f1a9e429267de2c.
Files selected for processing (4) * app/client/src/components/propertyControls/DraggableListCard.tsx (1 hunks) * app/client/src/components/propertyControls/ToolbarButtonListControl.tsx (1 hunks) * app/client/src/components/propertyControls/index.ts (2 hunks) * app/client/src/widgets/wds/WDSToolbarButtonsWidget/config/propertyPaneConfig/contentConfig.ts (1 hunks)
Files skipped from review due to trivial changes (2) * app/client/src/components/propertyControls/DraggableListCard.tsx * app/client/src/widgets/wds/WDSToolbarButtonsWidget/config/propertyPaneConfig/contentConfig.ts
Additional comments not posted (3)
app/client/src/components/propertyControls/ToolbarButtonListControl.tsx (2)
`9-33`: The implementation of `addOption` method correctly handles the addition of both buttons and separators. Good use of unique key generation and state management. --- `35-37`: The `getControlType` method correctly identifies the control type as "TOOLBAR_BUTTONS", aligning with the PR objectives.
app/client/src/components/propertyControls/index.ts (1)
Line range hint `78-130`: The addition of `ToolbarButtonListControl` to the `PropertyControls` export object is correctly implemented, ensuring the new control is available for use.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.