appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
32.47k stars 3.52k forks source link

[Bug]: If we click on the commit icon of a github connected app on airgapped, the app crashes. #33812

Open btsgh opened 1 month ago

btsgh commented 1 month ago

Is there an existing issue for this?

Description

I have a git connected app connecting to a github repository [connected with internet], then go offline and click on the commit button - the app crashes. Expected behavior - app should not crash - this scenario should be handled gracefully

Steps To Reproduce

  1. Create an app on airgapped
  2. Go online
  3. Connect to git hub repository
  4. Now go offline
  5. Open the above app
  6. Click on the commit button App crashes.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Airgapped

btsgh commented 1 month ago

https://github.com/appsmithorg/appsmith/assets/101863839/4ecae023-c635-4027-9158-f0e40dd1f709

VigneswarV commented 2 weeks ago

I have Fixed and created a PR for this https://github.com/appsmithorg/appsmith/pull/34673

akshayvijayjain commented 2 weeks ago

@brayn003 @btsgh Please help with reviewer for the pr https://github.com/appsmithorg/appsmith/pull/34673