appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.83k stars 3.65k forks source link

[Bug]: Cyclic dependency error loop issue when using Table.updated row in table editable column #33860

Open rishabhrathod01 opened 3 months ago

rishabhrathod01 commented 3 months ago

Is there an existing issue for this?

Description

Need to resolve the cyclic dependency loop error for the case when user tries to bind a widget to a property that is not defined.

image

Steps To Reproduce

  1. Add a Table widget
  2. Bind data
  3. Make column editable
  4. Go to the column settings > validation and bind to {{Table1.updatedRow}}

Notice the cyclic dependency error.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

1.26

rishabhrathod01 commented 3 months ago

I paused working on this for 1.5 days due to the critical issue being prioritized. Continuing work here.

rishabhrathod01 commented 3 months ago

The root cause of the cyclic dependency issue is the derived property Table1.updatedRow depending on Table1.primaryColumns due to how we generate the dependency for the derived property. This dependency is not valid. Will be considering new way to generate dependency for derived property like such and resolve this issue.

rishabhrathod01 commented 3 months ago

Documentation of steps taken to resolve this issue that weren't fruitful.