appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.96k stars 3.66k forks source link

[Feature]: Ability to set the title of the tab dynamically #34260

Open Nikhil-Nandagopal opened 3 months ago

Nikhil-Nandagopal commented 3 months ago

Is there an existing issue for this?

Summary

End users have many tabs open of their appsmith apps and they would like to have unique titles for the tabs based on the tickets they are looking up so that they can go to the right tab quickly

Why should this be worked on?

This was requested by enterprise customers and is important for operational use cases as it reduces the time for users to switch tabs

deepthin3 commented 3 weeks ago

Hi, Can you please provide some more context here....Do we want to dynamically set (not manually) the tab titles?...What does - tickets user is looking for, mean here?

rohan-arthur commented 3 weeks ago

@deepthin3 I explain the requirement in this attached video

https://github.com/user-attachments/assets/c875ab07-835e-4e52-8dab-94bcf6f857bb

saicharan-zemoso commented 3 weeks ago

Hello @rohan-arthur and @carinanfonseca , Thank you for the requirement video.

can you please provide some more context and some clarification on this feature.

I have tried and implemented the feature and I am able to set the name of the tab dynamically but the issue is that : problem 1. what was given in the lable property will be displayed in the title of the property pane and in the tabObjs section of Tab widget. SS: The property pane of Tab widget. Screenshot from 2024-09-10 14-58-41

The title of the tab: Screenshot from 2024-09-10 15-00-13

problem 2. If this is expected behaviour then we can go ahead with this implementation. and If this is not an expected behaviour the we have to show the evaluated value instead of the text. problem 2.1 If we show the evaluated value then the problem arises when the user tries to edit that name of the tab. what should be the expected behaviour.

We can see the same behaviour in the ButtonGroupWidget and it has the same issues and the problem 2 was not handled in this widget. ss: Screenshot from 2024-09-10 15-08-50

title of the Button property pane: Screenshot from 2024-09-10 15-09-15

saicharan-zemoso commented 3 weeks ago

Hello @rohan-arthur here is a video of the feature and the problems:

https://github.com/user-attachments/assets/3ba2d314-57ca-454a-81c3-67d46e95deae

rohan-arthur commented 3 weeks ago

@saicharan-zemoso thank you for the explanation. Showing the expression seems like not ideal behaviour, but we can also keep it out of scope of this issue - Someone from the team will get back to you on this!

rohan-arthur commented 2 weeks ago

@saicharan-zemoso I have created a separate issue for the problem with display name: https://github.com/appsmithorg/appsmith/issues/36236

Please proceed with this one

saicharan-zemoso commented 2 weeks ago

Hello @rohan-arthur , I have raised a PR for this issue here is the link : #36275

rohan-arthur commented 2 weeks ago

@rahulbarwal this one is for you