search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.83k stars 3.65k forks source link

chore: WDS spacing scale refinements #34581

Open ichik opened 2 months ago

ichik commented 2 months ago

There is a number of things that should be improved regarding out inner and outer spacing:

  1. We apply ratios to V in the formula, perhaps it should be more than that because otherwise effects of theme ratios are a bit static/limited in effect.
  2. We have a bunch of values in the middle that we don't use (not as big of a problem). Outer spacing also doesn't use tokens smaller than 3 seemingly (this is more indicative of a problem). Overall steepness of curves as well as their formulas can/should change.
  3. Sometimes outer spacing is not exactly significantly bigger than inner one. See attached screenshot where spacing between input label and input is inner-spacing-3 and between input widget and radio group widget it's outer-spacing-3. They're ~9 and ~11 px respectively, optically seem the same.
  4. We occasionally use impromer tokens, on the same screenshot space between radio group label and radios is defined with outer-spacing-3 token instead of inner.
  5. Changes to scale may require changing which tokens are used where especially in zones/sections/canvas.

image

ichik commented 2 months ago

Please add your planning poker estimate with Zenhub @KelvinOm