[Feature]: Support Supabase S3 Datasource

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.

https://www.appsmith.com

Apache License 2.0

32.45k stars 3.51k forks source link

[Feature]: Support Supabase S3 Datasource #34728

Open ame-appsmith opened 1 week ago

ame-appsmith commented 1 week ago

Is there an existing issue for this?

[X] I have searched the existing issues

Summary

Supabase has recently made its storage S3 compatible as per this article from April, 18th, 2024. At this juncture, it is not possible to connect to Supabase's S3 storage because the error SignatureDoesNotMatch: The request signature we calculate does not match the signature. gets returned when testing the configuration in Appsmith's S3 plugin. We need to figure out the underlying issue and provide a fix to make our S3 plugin compatible with Supabase S3's storage.

More info in this Slack thread.

Why should this be worked on?

Allowing users to connect to Supabase's S3 storage would enhance the user experience since Supabase is very popular and more users will start using this.

AnnaHariprasad5123 commented 1 week ago

Hi @ame-appsmith, @Nikhil-Nandagopal, I am willing to work on this. I have just created a Supabase account and a new project, and I have set up the access key and secret key.

We need to provide Supabase as an S3 service in the S3 plugin, right?

Nikhil-Nandagopal commented 1 week ago

@AnnaHariprasad5123 yes that is correct

NilanshBansal commented 6 days ago

@AnnaHariprasad5123 thanks for showing interest in contributing. Please go ahead. Let us know if you face any challenges.

akshayvijayjain commented 2 days ago

@NilanshBansal , @Nikhil-Nandagopal

here, the supabase is similar to firebase and firestore, so putting this supabase datasource in firestore plugin may be better. https://github.com/appsmithorg/appsmith/tree/master/app/server/appsmith-plugins/firestorePlugin Please let us know your thoughts.

we sensed this somehow while putting this supabase integration in aws s3 plugin, the apis are creating type conflicts. but still I am not an expert here. so request your recommendation. cc @AnnaHariprasad5123

Nikhil-Nandagopal commented 2 days ago

@akshayvijayjain we're not talking about supabase integration. We're talking about support for Supabases S3 storage which is just an S3 compliant file storage. https://supabase.com/blog/s3-compatible-storage

AnnaHariprasad5123 commented 1 day ago

Hi @NilanshBansal, I raised a draft PR and mentioned the issue I faced. Let me know your suggestions.

Nikhil-Nandagopal commented 1 day ago

@AnnaHariprasad5123 can you also share a video showcasing upload and file retrieval functionality with Google and Supabase?

AnnaHariprasad5123 commented 10 hours ago

Hi @Nikhil-Nandagopal, Sorry for the delay.

Are you asking from the GCP and Supabase websites or from the Appsmith S3 datasource? I haven't implemented file upload for Supabase because the listObjectFromBucket function is not working. I'm stuck on this issue and couldn't move forward, which is why I raised a draft PR. I need to know whether to continue or not because of the type conflicts.