search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.79k stars 3.63k forks source link

[Bug]: Merging a branch has no affect on Rest APIs #35011

Open shadabbuchh opened 1 month ago

shadabbuchh commented 1 month ago

Is there an existing issue for this?

Description

When we merge a branch into master, the queries of the other branch are not replicated in the master branch.

Steps To Reproduce

  1. Connect an app to git & create an API in master such that the URL is incomplete and commit the changes.
  2. Create a new branch (NewBranch) from master.
  3. In the NewBranch go to the above query & enter the correct URL such that we get a response on running the same and commit the changes.
  4. Merge NewBranch into master.

Expected: The API master should also have the complete URL and it should fetch a result same as in NewBranch. Actual: The API does not fetch any response as it still remains incomplete after the merge.

PS: I tried the above on a git imported app, but the same error should occur while performing the above steps.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

https://jam.dev/c/2dd8a8d9-2221-496b-af1c-35905b77ae22

Version

Cloud

btsgh commented 1 month ago

@nidhi-nair - wondering if this can be picked as part of cross referencing itself and fixed? So any api that I create and commit and merge it to another branch, the api does get merged but the url is broken .. this seems like quite a critical issue - and has leaked into production as well

nidhi-nair commented 1 month ago

Whoops, guess we missed that. I suppose this is an independent issue altogether so it would make sense to pick it up as such as well. I'm going to reassign this to @rohan-arthur so we can start to make plugin specific git handling be more self-serve.