appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.95k stars 3.66k forks source link

[Bug]: On and discarding changes made to application icon & pulling form local we see uncommitted changes #35170

Open shadabbuchh opened 2 months ago

shadabbuchh commented 2 months ago

Is there an existing issue for this?

Description

After successfully discarding & pulling from local we still see some uncommitted changes.

Note: Please use branch1 in the below app.

Steps To Reproduce

  1. Go to a git connected app in https://ee-4056.dp.appsmith.com/.
  2. Make some changes & then discard the same.

Expected: After discarding changes, no further uncommitted changes should be seen. Actual: We are seeing uncommitted changes after successful discard as well.

Public Sample App

https://ee-4056.dp.appsmith.com/app/oldapp-dstesting1-9-24/oauth20-669e0dca434f472715f43ba0?branch=branch1

Environment

Deploy Preview

Severity

High (Blocker to building or releasing)

Issue video log

https://jam.dev/c/4516be78-985b-4a3d-9f2f-8e91c2dc05c8

Version

Cloud

shadabbuchh commented 2 months ago

Diff:

Screenshot 2024-07-25 at 12 24 08 PM
shadabbuchh commented 2 months ago

Link to the repo: https://github.com/shadabbuchh/release_EE_Cross

shadabbuchh commented 2 months ago

After discussing with @nidhi-nair, we concluded that the root issue lies in the fact that application icon information is not being stored upon app creation. Consequently, when I changed the app icon in a different branch and then discarded the changes, there was no stored information to revert to, resulting in uncommitted changes being displayed.

nidhi-nair commented 1 month ago

Lowering priority and switching labels since the issue is not reproducible anymore and isn't related to git.