appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.64k stars 3.74k forks source link

[Feature]: Improved Error Handling for OIDC SSO Login Issues: Redirect to Informative Error Page on Missing Email Attribute #35244

Open ame-appsmith opened 3 months ago

ame-appsmith commented 3 months ago

Is there an existing issue for this?

Summary

Context: The user is experiencing login issues with OIDC SSO in appsmith due to a missing email address in the account configuration. This results in redirection to an invalid URL confusing users and support staff. This is the error displayed in the logs:

backend stdout | [2024-07-29 01:15:42,298] requestId= userEmail= traceId= spanId= - In the login failure handler. Cause: [invalid_user_info_response] An error occurred reading the UserInfo response: Missing attribute 'email' in attributes
backend stdout | org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_user_info_response] An error occurred reading the UserInfo response: Missing attribute 'email' in attributes

However, in the UI, the end user gets redirected to an invalid URL: https://user/login?error=true To improve the user experience, Appsmith should redirect to a proper error page and display a message indicating an issue with their account configuration.

Why should this be worked on?

Better error handling would improve the user experience.

amenasse commented 3 months ago

As Appsmith is redirecting to an invalid url this issue should be labelled as a bug