search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
33.79k stars 3.63k forks source link

[Feature]: be able to use iframes without padding #35555

Open toxicflux opened 1 month ago

toxicflux commented 1 month ago

Is there an existing issue for this?

Summary

Iframes are currently useless for small components because padding is added and is not related to external component. This makes iframes very difficult to use since it is not possible to align smaller iframes as close as I want. Making height smaller adds an annoying scroll bar on overflow.

image

I want to have zero padding for iframe or possibility to remove it. Custom widget needs a lot of copy and pasting to be able to use at large scale as component library, maintainace of these components are unclear and performance is really poor compared to iframes. It is not possible to solve by putting iframe inside Custom component.

Why should this be worked on?

We want to replace small components with components of our own design, hosted externally. Iframes works for larger widgets, but is useless for smaller widgets because of padding (left, right, top and bottom). The padding sometimes makes it difficult to implement larger widgets as well.

Nikhil-Nandagopal commented 1 month ago

@toxicflux have you tried using the custom widget for this?

toxicflux commented 1 month ago

Yes, I've tried Custom widget for this (as screenshot show/described above). Custom widget do not work for reusable code, it has severe performance issues and it doesn't work putting an iframe inside a custom widget (as described above). I want to be able to make a reusable library of components that replace components like inputs, button, select etc. in appsmith. We have 20+ applications and copy/paste custom widget is really not an option.

Nikhil-Nandagopal commented 1 month ago

Ok I'm not sure iFrame is the best idea either because many iFrames on a single page will likely lead to a performance issue as well. Could you tell us why you are looking to customise the components? We are working on reusable widgets as well but it doesn't seem like that will suit your use case either.

toxicflux commented 1 month ago

We need to style our applications to meet customer requirements, meaning we want to override the style of basic components such as buttons, inputs, selects. The styling of appsmith components are limited, the best would be if we could provide our own component library.

carinanfonseca commented 1 month ago

@toxicflux, thank you for raising this topic. We’d like to understand more about the use cases and limitations, which will help us identify what's missing in the Appsmith product and potential improvements.

Please feel free to book a time that works for you. I look forward to speaking with you.

nikguhl89 commented 3 weeks ago

This is also something I have had issues with. I am trying to display an external website within an iframe, but it is zoomed in too much to fully fit the page in view. This is especially a problem on the mobile view. If I had the ability to fit content to width on the iframe at least this would be much more usable. I tried doing a custom iframe, but I was not able to interact with my content, only display it.