search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.33k stars 3.72k forks source link

[Improvement]: Migrate JS Library Icons to Use Internal CDN Instead of Third-Party URLs #35560

Open rishabhrathod01 opened 2 months ago

rishabhrathod01 commented 2 months ago

Is there an existing issue for this?

Summary

Within the JS Library feature of our application, we currently rely on third-party URLs to source icons for various JavaScript libraries. This dependency on external resources can lead to issues such as broken icons and inconsistent user experiences if those URLs become unavailable.

Proposed Solution:

Migrate all JS Library icons to be hosted on our internal CDN to ensure their consistent availability and performance. Update the icon fields in the JS Library configurations to point to the new CDN-hosted versions.

Benefits:

Ensures that icons for JS libraries are always available and not dependent on external services. Potentially faster icon loading times by reducing reliance on third-party hosts. Enhanced security and greater control over the assets used in our application.

Why should this be worked on?

This should be worked on to ensure reliability, performance, and security. By moving JS Library icons to our internal CDN, we eliminate the risk of broken icons from third-party outages, reduce load times, and maintain better control over our resources. This leads to a more consistent and dependable user experience.

DivyDeshmukh commented 2 months ago

Starting my contribution to open source with this repository - attempt #35560

rohan-arthur commented 2 months ago

@DivyDeshmukh thanks for you interest in contributing to appsmith! This particular issue may not be suitable, because we will need to get the relevant icons, etc. Can I encourage you to take a look at the issues with label Inviting contribution? Here's the filter: https://github.com/appsmithorg/appsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Inviting+Contribution%22

DivyDeshmukh commented 2 months ago

@DivyDeshmukh thanks for you interest in contributing to appsmith! This particular issue may not be suitable, because we will need to get the relevant icons, etc. Can I encourage you to take a look at the issues with label Inviting contribution? Here's the filter: https://github.com/appsmithorg/appsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Inviting+Contribution%22

Ok thanks for informing me.