appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.6k stars 3.73k forks source link

[Bug]: An empty toast is seen when the message section is empty in the showAlert function #37122

Open laveena-en opened 2 weeks ago

laveena-en commented 2 weeks ago

Is there an existing issue for this?

Description

An empty toast is seen when the message section is empty in the showAlert function. Ideally, the toast should contain an error suggesting to the user that the message value hasn't been provided

Steps To Reproduce

  1. D&D a button widget onto the canvas
  2. Configure the onClick() function to show an alert. And keep the message section empty
  3. Click on the button
  4. Notice that an empty toast is seen

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://jam.dev/c/a603de2b-b577-4bd0-844a-3387b6f336b1

Version

Cloud

shubham88fru commented 2 weeks ago

Hi @rohan-arthur @laveena-en , If anyone of you can provide the message that needs to be displayed and give some general directions as to which part of code to look into, I can try working and fixing this bug. Thanks.

laveena-en commented 1 week ago

@rohan-arthur Would something like "Missing 'Message' parameter" suffice? Also, @NilanshBansal Can you please help @shubham88fru with where code changes would be required here?

shubham88fru commented 1 week ago

Thanks for getting back @laveena-en. @NilanshBansal @rohan-arthur just some general directions are fine and I'll be able to take it from there. Thanks!

NilanshBansal commented 1 week ago

@shubham88fru I would request you to please check the issues open for external contribution. Unfortunately, this issue needs some context and is for the internal team to solve. You can find a list of open issues for contribution with the label Inviting Contribution. Please feel free to pick up any issue from this list: https://github.com/appsmithorg/appsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Inviting+Contribution%22