fix: Instance admin not updating when email added via env variable

[trishaanand]

Using feature flagged function to evict cache to ensure correct cache line gets evicted depending on the flag

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes https://github.com/appsmithorg/appsmith/issues/33741

Automation

/test all

:mag: Cypress test results

[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11914552417 Commit: d4aed1f340e907c588f156d83c32e67c1ab4da18 Cypress dashboard. Tags: @tag.All Spec: The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/FormLogin/EnableFormLogin_spec.js
2. cypress/e2e/Regression/ClientSide/Github/EnableGithub_spec.ts

List of identified flaky tests.

---

Tue, 19 Nov 2024 15:04:20 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• [ ] Yes
• [ ] No

Summary by CodeRabbit

• New Features

  • Enhanced migration functionalities for database schema updates and permission management.
  • Added methods for managing SSL settings for MSSQL datasources and updating Oracle plugin configurations.
  • Improved query performance with the creation of new indexes.

• Bug Fixes

  • Updated permission management for super users and system themes, ensuring proper access.

• Chores

  • Minor formatting adjustments and import updates for code clarity.

[coderabbitai[bot]]

Walkthrough

The changes introduced in this pull request involve significant updates to the DatabaseChangelog2 and MigrationHelperMethods classes, focusing on database migration functionalities. Key modifications include the replacement of CacheableRepositoryHelper with PermissionGroupRepository in methods related to user permissions and cache eviction. New migration methods for MSSQL and Oracle plugins have been added, along with enhancements to index creation for improved query performance. The updates aim to refine permission management and ensure proper plugin configurations.

Changes

File Path	Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/DatabaseChangelog2.java	- Updated updateSuperUsers method to use PermissionGroupRepository. - Added new migration methods: addSslModeSettingsForExistingMssqlDatasource, addOraclePlugin, and updateOraclePluginName. - Modified createThemesIndices and addPermissionGroupIndex for index management. - Updated createSystemThemes3 for anonymous user access to themes.
app/server/appsmith-server/src/main/java/com/appsmith/server/migrations/MigrationHelperMethods.java	- Changed evictPermissionCacheForUsers method to use PermissionGroupRepository. - Minor formatting and import adjustments.

Possibly related PRs

• #36862: This PR modifies the DatabaseChangelog1 class, which is related to database management and migration functionalities, similar to the changes made in the DatabaseChangelog2 class in the main PR. Both PRs involve updates to migration methods and enhancements to database indexing.

Suggested labels

Bug

Suggested reviewers

• nidhi-nair
• AnaghHegde
• abhvsn

Poem

In the land of code where changes flow,
Permissions shift and plugins grow.
With indexes set and caches cleared,
A migration tale that’s now revered.
Super users updated, themes in sight,
A database dance, oh what a delight! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.