search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.67k stars 3.75k forks source link

chore: Refactor observability setup. Migrate monitoring configuration… #37577

Closed subhrashisdas closed 2 days ago

subhrashisdas commented 2 days ago

Description

Cleanup of Monitoring will be done in multiple phases to avoid any disruptions. The first PR is to remove the default monitoring Compose files.

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11929368913 Commit: af90c5f15a22fef1ec52636fae9cb864e5c660dc Cypress dashboard. Tags: @tag.Sanity Spec:

Wed, 20 Nov 2024 08:55:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Summary by CodeRabbit

coderabbitai[bot] commented 2 days ago

Walkthrough

The changes involve the deletion of several configuration files related to observability tools in a Docker setup. The removed files include configurations for Docker Compose, Grafana dashboards, data sources, and Prometheus settings, as well as a local Tempo configuration. These deletions indicate a significant alteration in the observability setup, potentially simplifying or changing the approach to monitoring and logging within the application.

Changes

File Path Change Summary
utils/observability/docker-compose.yml Deleted configuration for Docker Compose, including services for Tempo, Prometheus, and Grafana.
utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml Deleted Grafana dashboard provisioning configuration.
utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json Deleted Grafana dashboard for visualizing logs, traces, and metrics.
utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json Deleted Grafana dashboard specifically for monitoring Redis operations.
utils/observability/docker/grafana/provisioning/datasources/datasource.yml Deleted configuration for data sources (Prometheus, Tempo, Loki) in Grafana.
utils/observability/docker/prometheus/prometheus.yml Deleted configuration settings for Prometheus monitoring.
utils/observability/docker/tempo/tempo-local.yaml Deleted configuration for local Tempo instance setup.

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

🌟 In the land of code where changes flow,
Configs were deleted, and off they go!
With observability tools now out of sight,
A simpler path may soon feel just right.
Farewell to the dashboards and YAMLs galore,
New adventures await, let’s code even more! 🚀

📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 7e13fcbe7f35337890a09a1082e9a321a42df357 and af90c5f15a22fef1ec52636fae9cb864e5c660dc.
📒 Files selected for processing (7) * `utils/observability/docker-compose.yml` (0 hunks) * `utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml` (0 hunks) * `utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json` (0 hunks) * `utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json` (0 hunks) * `utils/observability/docker/grafana/provisioning/datasources/datasource.yml` (0 hunks) * `utils/observability/docker/prometheus/prometheus.yml` (0 hunks) * `utils/observability/docker/tempo/tempo-local.yaml` (0 hunks)
💤 Files with no reviewable changes (7) * utils/observability/docker-compose.yml * utils/observability/docker/grafana/provisioning/dashboards/dashboard.yml * utils/observability/docker/grafana/provisioning/dashboards/logs_traces_metrics.json * utils/observability/docker/grafana/provisioning/dashboards/redis_dashboard.json * utils/observability/docker/grafana/provisioning/datasources/datasource.yml * utils/observability/docker/prometheus/prometheus.yml * utils/observability/docker/tempo/tempo-local.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.