Open ambati-vedapriya opened 1 day ago
The changes primarily involve enhancements to error handling and response management in the PluginActionSaga.ts
file, along with the introduction of new error codes and types in the Java backend. The executePluginActionSaga
function has been updated to improve response structure and error clarity. Additionally, a new enum constant for timeout errors has been added, along with a validation check for timeout durations in action execution. These modifications aim to provide better error feedback and ensure robust action execution.
File | Change Summary |
---|---|
app/client/src/sagas/ActionExecution/PluginActionSaga.ts | Added variable data: ActionExecutionResponse ; updated error checking and response handling logic. |
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions/AppsmithPluginError.java | Introduced new enum constant PLUGIN_TIMEOUT_OUT_OF_RANGE with HTTP error code 504. |
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions/AppsmithPluginErrorCode.java | Added PLUGIN_TIMEOUT_OUT_OF_RANGE error code "PE-QRY-5001"; minor syntax adjustment to existing code. |
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/ErrorType.java | Added new error type VALIDATION_ERROR . |
app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java | Added validation for timeoutDuration in getActionExecutionResult method; minor formatting changes. |
sequenceDiagram
participant Client
participant PluginActionSaga
participant Server
participant ErrorHandler
Client->>PluginActionSaga: executePluginAction()
PluginActionSaga->>Server: API Call
Server-->>PluginActionSaga: Response
PluginActionSaga->>PluginActionSaga: Check response success
alt Success
PluginActionSaga->>Client: executePluginActionSuccess(data)
else Error
PluginActionSaga->>ErrorHandler: Handle error
ErrorHandler-->>PluginActionSaga: Return structured error response
PluginActionSaga->>Client: executePluginActionFailure(error)
end
In code and logic, changes unfold,
New structures and errors, a story told.
With validation in place, and clarity bright,
Our saga now shines, a beacon of light.
So here's to the code, refined and true,
In the realm of development, we bid you adieu!
🎉✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issue_37019
Fixed the bug range annotation is not working for action configuration
RangeTimeout.webm
Summary by CodeRabbit
New Features
Bug Fixes
Documentation