appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.66k stars 3.75k forks source link

fix:Resolved the bug range annotation is not working for action configuration 37019 #37599

Open ambati-vedapriya opened 1 day ago

ambati-vedapriya commented 1 day ago

Issue_37019

Fixed the bug range annotation is not working for action configuration

RangeTimeout.webm

Summary by CodeRabbit

coderabbitai[bot] commented 1 day ago

Walkthrough

The changes primarily involve enhancements to error handling and response management in the PluginActionSaga.ts file, along with the introduction of new error codes and types in the Java backend. The executePluginActionSaga function has been updated to improve response structure and error clarity. Additionally, a new enum constant for timeout errors has been added, along with a validation check for timeout durations in action execution. These modifications aim to provide better error feedback and ensure robust action execution.

Changes

File Change Summary
app/client/src/sagas/ActionExecution/PluginActionSaga.ts Added variable data: ActionExecutionResponse; updated error checking and response handling logic.
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions/AppsmithPluginError.java Introduced new enum constant PLUGIN_TIMEOUT_OUT_OF_RANGE with HTTP error code 504.
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions/AppsmithPluginErrorCode.java Added PLUGIN_TIMEOUT_OUT_OF_RANGE error code "PE-QRY-5001"; minor syntax adjustment to existing code.
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/ErrorType.java Added new error type VALIDATION_ERROR.
app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java Added validation for timeoutDuration in getActionExecutionResult method; minor formatting changes.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant PluginActionSaga
    participant Server
    participant ErrorHandler

    Client->>PluginActionSaga: executePluginAction()
    PluginActionSaga->>Server: API Call
    Server-->>PluginActionSaga: Response
    PluginActionSaga->>PluginActionSaga: Check response success
    alt Success
        PluginActionSaga->>Client: executePluginActionSuccess(data)
    else Error
        PluginActionSaga->>ErrorHandler: Handle error
        ErrorHandler-->>PluginActionSaga: Return structured error response
        PluginActionSaga->>Client: executePluginActionFailure(error)
    end

In code and logic, changes unfold,
New structures and errors, a story told.
With validation in place, and clarity bright,
Our saga now shines, a beacon of light.
So here's to the code, refined and true,
In the realm of development, we bid you adieu!
🎉✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.