fix: shared drive support added for google sheets

sneha122 commented 1 day ago

Description

This PR adds support for accessing shared drive files for google sheets integration

Fixes #37598 or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11934080947 Commit: ac6eade4ac6df978f8384fadd1df9e5c8191c9fb Cypress dashboard. Tags: @tag.Datasource Spec:
Wed, 20 Nov 2024 13:51:58 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features
- Enhanced API requests for Google Sheets and Drive to include items from all drives.
Bug Fixes
- Improved data retrieval processes by adjusting query parameters for API calls.

coderabbitai[bot] commented 1 day ago

Walkthrough

The changes in this pull request involve modifications to the URI construction in the getExecutionClient methods of the FileInfoMethod and FileListMethod classes within the Google Sheets plugin. The updates include the addition of the query parameter supportsAllDrives=true and includeItemsFromAllDrives=true, enhancing the API requests to accommodate all drives in Google Drive. The overall structure and error handling of the methods remain unchanged.

Changes

File	Change Summary
`app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileInfoMethod.java`	Updated URI in `getExecutionClient` to include `supportsAllDrives=true`.
`app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileListMethod.java`	Updated URI in `getExecutionClient` to include `includeItemsFromAllDrives=true` and `supportsAllDrives=true`.

Assessment against linked issues

Objective	Addressed	Explanation
Check if Google APIs provide support for shared drive for Google sheets integration (#37598)	✅

Possibly related PRs

#36125: This PR modifies the Google Sheets plugin's authorization scopes, which is directly related to the changes in the FileInfoMethod class that also involve API request parameters for Google Sheets.
#36264: This PR addresses the default method value in the Google Sheets datasource, which is relevant to the changes made in the FileInfoMethod class regarding API request handling.
#37006: This PR introduces changes to the Google Sheets plugin's method for retrieving authorized sheet IDs, which aligns with the modifications in the FileInfoMethod class that also deal with API request parameters and authorization.

Suggested labels

DailyPromotionBlocker

Suggested reviewers

ApekshaBhosale
NilanshBansal
sneha122

🎉 In the realm of code, where APIs play,
A tweak here and there, brightens the day!
With drives all supported, the data flows free,
Google Sheets integration, as smooth as can be!
So here's to the changes, both clever and neat,
In the world of development, we can't be beat! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sneha122 commented 1 day ago

/build-deploy-preview skip-tests=true

github-actions[bot] commented 1 day ago

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11934033608. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 37602. recreate: .

github-actions[bot] commented 1 day ago

Deploy-Preview-URL: https://ce-37602.dp.appsmith.com

appsmithorg / appsmith