fix: Min width in certain ADS Button usage

hetunandu commented 1 day ago

Description

Remove height override in Workspace add button
Remove min width in Debugger trigger button

Fixes #37623

Automation

/ok-to-test tags="@tag.Sanity"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11953373643 Commit: 9acd2b982c393841d472bb91576f997cd8a8df3a Cypress dashboard. Tags: @tag.Sanity Spec:
Thu, 21 Nov 2024 13:18:43 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features
- Introduced new styled components for enhanced workspace layout: WorkspaceDropDown, WorkspaceSection, and ApplicationContainer.
- Added functionality for creating and managing workspaces, including a new button in the LeftPaneSection.
- Enhanced application display logic based on Anvil feature status.
Bug Fixes
- Improved error handling and state management for workspace and application fetching.
Style
- Updated DebuggerTrigger to use a new styled button for improved design consistency.
- Customized button appearance in the debugger with a new styled component.
Documentation
- Enhanced overall component structure for better readability and maintainability.

coderabbitai[bot] commented 1 day ago

Walkthrough

The changes in this pull request primarily focus on enhancing the Applications and Debugger components. New styled components are introduced to improve the layout and user interface, including workspace management features and a refined button component in the debugger. The logic for displaying applications based on feature flags is also updated, alongside improvements in error handling and state management. Overall, the modifications aim to provide a more organized and visually appealing user experience.

Changes

File Path	Change Summary
app/client/src/ce/pages/Applications/index.tsx	Added styled components: `WorkspaceDropDown`, `WorkspaceSection`, `ApplicationContainer`. Updated `LeftPaneSection` to include workspace creation logic. Modified `ApplicationsSection` for feature-based application display. Refined `deleteApplication` function. Introduced `submitCreateWorkspaceForm` function. Enhanced error handling and state management.
app/client/src/components/editorComponents/Debugger/index.tsx	Removed `Button` import, replaced with `Styled.DebuggerTriggerButton`. Maintained existing button properties and tooltip logic.
app/client/src/components/editorComponents/Debugger/styles.ts	Introduced `DebuggerTriggerButton` styled component with customized minimum width.
app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx	Removed CSS related to `.ads-v2-select > .rc-select-selector` from `MainConfiguration`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ApplicationsComponent
    participant WorkspaceService
    participant DebuggerComponent

    User->>ApplicationsComponent: Create Workspace
    ApplicationsComponent->>WorkspaceService: submitCreateWorkspaceForm(data)
    WorkspaceService-->>ApplicationsComponent: Workspace Created
    ApplicationsComponent->>ApplicationsComponent: Fetch All Workspaces
    ApplicationsComponent-->>User: Display Updated Workspace List

    User->>DebuggerComponent: Trigger Debugger
    DebuggerComponent->>DebuggerTrigger: Styled Button Clicked
    DebuggerTrigger-->>DebuggerComponent: Execute Debugger Logic

Assessment against linked issues

Objective	Addressed	Explanation
Fix button size inconsistencies (37623)	✅
Improve button appearance in debugger (37623)	✅

Possibly related PRs

#37338: Updates the minimum width of ADS buttons, relevant to the button styling changes in this PR.
#37382: Addresses button sizing issues, linking to the focus on button properties in the current changes.

Suggested labels

Task

Suggested reviewers

ankitakinger
albinAppsmith

🎉 In the land of code where changes bloom,
New buttons and styles make the UI zoom!
Workspaces created with a click and a cheer,
Debugger's new look brings the users near.
With errors handled and logic refined,
A smoother experience for all, we designed! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

hetunandu commented 1 day ago

/build-deploy-preview

github-actions[bot] commented 1 day ago

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11948472814. Workflow: On demand build Docker image and deploy preview. skip-tests: . env:. PR: 37624. recreate: .

github-actions[bot] commented 23 hours ago

Deploy-Preview-URL: https://ce-37624.dp.appsmith.com

hetunandu commented 20 hours ago

/build-deploy-preview

github-actions[bot] commented 20 hours ago

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11951836554. Workflow: On demand build Docker image and deploy preview. skip-tests: . env:. PR: 37624. recreate: .

appsmithorg / appsmith