search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.66k stars 3.75k forks source link

chore: add executeActionDTO as additional parameter to be used when creating query for AppsmithAI plugin queries #37631

Open nsarupr opened 22 hours ago

nsarupr commented 22 hours ago

Description

Add executeActionDTO as an additional parameter when executing queries for Appsmith AI Plugin

Fixes https://github.com/appsmithorg/appsmith/issues/37637

Automation

/ok-to-test tags="@tag.Sanity"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11949422399 Commit: 116c3842f59001837599aab01fb907e1e290cf45 Cypress dashboard. Tags: @tag.Sanity Spec:

Thu, 21 Nov 2024 09:04:26 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

coderabbitai[bot] commented 22 hours ago

Walkthrough

The pull request introduces modifications to the AppsmithAiPlugin class and related services, primarily updating method signatures to include an additional parameter, ExecuteActionDTO. This change affects the executeCommon method of AppsmithAiPluginExecutor and the createQuery methods across several service implementations. The updates maintain existing logic while enhancing the method interfaces to support more complex action execution scenarios.

Changes

File Change Summary
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/AppsmithAiPlugin.java Updated executeCommon method signature to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/AiFeatureService.java Modified createQuery method signature to accept ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/ImageCaptioningServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/ImageClassificationServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/ImageEntityExtractionServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/TextClassificationServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/TextEntityExtractionServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/TextGenerationServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/main/java/com/external/plugins/services/features/TextSummarizationServiceImpl.java Updated createQuery method to include ExecuteActionDTO.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/ImageCaptioningServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/ImageClassificationServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/ImageEntityExtractionServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/TextClassificationServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/TextEntityExtractionServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/TextGenerationServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.
app/server/appsmith-plugins/appsmithAiPlugin/src/test/java/com/external/plugins/services/features/TextSummarizationServiceImplTest.java Updated test methods to include ExecuteActionDTO in createQuery calls.

Possibly related PRs

Suggested labels

Enhancement, Bug, Task, ok-to-test, JS Objects, Javascript Product, Query & JS Pod

Suggested reviewers

🎉 In the land of code, where changes flow,
New parameters added, to help us grow.
ExecuteActionDTO, a friend so true,
Enhancing our queries, making them new!
With tests updated, we march ahead,
In the realm of plugins, where progress is spread! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.