search

appsmithorg / appsmith

Platform to build admin panels, internal tools, and dashboards. Integrates with 25+ databases and any API.
https://www.appsmith.com
Apache License 2.0
34.66k stars 3.75k forks source link

chore: Update size of sidebar + remove using sheet #37638

Open jsartisan opened 20 hours ago

jsartisan commented 20 hours ago

https://github.com/user-attachments/assets/94c51ceb-d0cd-47b8-9766-a160f43b6f6f

/ok-to-test tags="@tag.Anvil"

Summary by CodeRabbit

Release Notes

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11953544047 Commit: 40e605795762c6a5822f1cbd6aed5f0aaf99a239 Cypress dashboard. Tags: @tag.Anvil Spec:

Thu, 21 Nov 2024 13:11:13 UTC

coderabbitai[bot] commented 19 hours ago

Walkthrough

The pull request introduces several modifications to the sidebar components in the design system. Key changes include the removal of the isMobile state from the _Sidebar component, enhancing the component's logic. The _SidebarContent component's title rendering is improved with additional styling props. The SidebarInset component is entirely removed, and adjustments are made to the _SidebarProvider regarding sidebar width styling. The CSS for the sidebar is updated for better responsiveness, and various story exports for the sidebar are simplified by removing the SidebarInset and variant properties.

Changes

File Change Summary
app/client/packages/design-system/widgets/src/components/Sidebar/src/Sidebar.tsx Removed isMobile state and related conditional rendering for mobile view. Focused on rendering with CSSTransition.
app/client/packages/design-system/widgets/src/components/Sidebar/src/SidebarContent.tsx Enhanced title rendering with additional props for styling. Removed padding from the containing Flex component.
app/client/packages/design-system/widgets/src/components/Sidebar/src/SidebarInset.tsx Deleted the SidebarInset component entirely.
app/client/packages/design-system/widgets/src/components/Sidebar/src/SidebarProvider.tsx Added side prop to _SidebarProvider, updated context value and removed sidebar width inline style.
app/client/packages/design-system/widgets/src/components/Sidebar/src/index.ts Removed export of SidebarInset.
app/client/packages/design-system/widgets/src/components/Sidebar/src/styles.module.css Updated CSS for .mainSidebar and .sidebar classes. Introduced new .sidebarTitle class and refined styles overall.
app/client/packages/design-system/widgets/src/components/Sidebar/stories/Sidebar.stories.tsx Removed SidebarInset from imports and stories. Simplified Default and SideRight story exports, introducing SideLeft.
app/client/packages/design-system/widgets/src/components/Sidebar/src/SidebarTrigger.tsx Updated icon rendering logic based on sidebar state and position.
app/client/packages/design-system/widgets/src/components/Sidebar/src/types.ts Added new types SidebarState and SidebarSide, updated related interfaces to enhance type safety.

Possibly related PRs

Suggested labels

Task, Enhancement, IDE Product, IDE Pod, ok-to-test

Suggested reviewers

🎉 In the sidebar's realm, changes unfold,
With titles more vibrant, and stories retold.
The inset departs, while transitions take flight,
A cleaner design, oh what a delight!
CSS dances, responsive and bright,
In the land of components, everything feels right! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
jsartisan commented 19 hours ago

@ichik updated the icons based on side.