coderabbitai[bot]
commented
15 hours ago Walkthrough
The pull request introduces modifications across multiple Cypress test files, primarily focusing on standardizing method names and enhancing the structure of test cases related to various data sources. Key changes include renaming the RunQueryNVerifyResponseViews method to runQueryAndVerifyResponseViews, updating method signatures to accept parameters as objects, and refining assertions for better clarity. Additionally, the Response class has undergone significant restructuring to improve response type management and validation logic. The overall aim is to enhance readability, maintainability, and consistency within the test suite and related components.
Changes
| File | Change Summary |
|---|---|
app/client/cypress/e2e/Regression/ClientSide/BugTests/Binding_Bug28287_Spec.ts |
Updated test for Bug 28287: added step to open response type menu and changed method for asserting response type visibility. |
app/client/cypress/e2e/Regression/ServerSide/Datasources/Redis_Basic_Spec.ts |
Renamed method RunQueryNVerifyResponseViews to runQueryAndVerifyResponseViews, updated method calls with parameters. |
app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts |
Renamed method RunQueryNVerifyResponseViews to runQueryAndVerifyResponseViews, added new test cases for CRUD validation. |
app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts |
Renamed method RunQueryNVerifyResponseViews to runQueryAndVerifyResponseViews, updated method to accept object parameters. |
app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres2_Spec.ts |
Renamed method RunQueryNVerifyResponseViews to runQueryAndVerifyResponseViews, updated parameters for flexibility. |
app/client/cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts |
Renamed method RunQueryNVerifyResponseViews to runQueryAndVerifyResponseViews, maintained test structure. |
app/client/cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts |
Updated method to runQueryAndVerifyResponseViews, removed visibility assertions for response types. |
app/client/cypress/e2e/Regression/ServerSide/QueryPane/Querypane_Mongo_Spec.js |
Updated validateRecordCount method to accept an object with count and operator. |
app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js |
Renamed method to runQueryAndVerifyResponseViews, updated to select response type from menu. |
app/client/cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts |
Renamed method to runQueryAndVerifyResponseViews, updated parameters for flexibility. |
app/client/cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts |
Updated method to runQueryAndVerifyResponseViews, added parameters for detailed query verification. |
app/client/cypress/support/Pages/DataSources.ts |
Added new method runQueryAndVerifyResponseViews, deprecated RunQueryNVerifyResponseViews. |
app/client/cypress/support/Pages/IDE/BottomPane/Response.ts |
Introduced new types and interfaces, updated methods for response type selection and validation. |
app/client/packages/design-system/ads/src/Icon/Icon.provider.tsx |
Added new icons and updated ICON_LOOKUP object. |
app/client/src/IDE/Components/BottomView.tsx |
Adjusted button positioning and state management logic. |
app/client/src/PluginActionEditor/components/PluginActionResponse/components/BindDataButton.tsx |
Updated button label from "Bind Data" to "Display on UI". |
app/client/src/PluginActionEditor/components/PluginActionResponse/components/NoResponse.tsx |
Updated layout and text display for no response. |
app/client/src/PluginActionEditor/components/PluginActionResponse/components/QueryResponseTab.tsx |
Introduced new component for displaying query responses. |
app/client/src/PluginActionEditor/components/PluginActionResponse/components/Table.tsx |
Updated styling and layout for the table component. |
app/client/src/PluginActionEditor/components/PluginActionResponse/components/constants.ts |
Added constant for tab bar height. |
app/client/src/ce/constants/messages.ts |
Added new constant for empty response instruction. |
app/client/src/components/editorComponents/ActionExecutionInProgressView.tsx |
Adjusted styling and properties of UI elements. |
app/client/src/components/editorComponents/EntityBottomTabs.tsx |
Simplified padding styles for tabs list. |
app/client/src/pages/Editor/QueryEditor/QueryDebuggerTabs.tsx |
Removed mock response objects and associated test cases. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant UI
participant API
participant DB
User->>UI: Trigger Query
UI->>API: Run Query
API->>DB: Execute Query
DB-->>API: Return Results
API-->>UI: Send Results
UI-->>User: Display ResultsAssessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Add query name .run as prefix for the header row. | ✅ | |
| Move number of records to the new header component. | ✅ | |
| Acquire query duration & HTTP status and add request execution time to redux. | ✅ | |
| On hover of query name and number of records, metadata of API run should show up as tooltip. | ✅ | |
| Move bind data button to the new header component & change its title. | ✅ | |
| Add content type icons (table, json, raw) to ADS. | ✅ | |
| Change result type from segmented control to a FAB with dropdown menu. | ✅ | |
| Change loading state button/spinner/spacing. | ✅ | |
| Change the empty state text and button alignment. | ✅ | |
| Update table appearance. | ✅ | |
| Table columns have a fixed width of 170px now, this needs to be updated to min-width. | ✅ | |
| Add status bar to error state, hide bind to UI button. | ✅ | |
| Account for scrollbars that are always shown. | ✅ | |
| Add dashed underline for status bar function name & meta. | ✅ | |
| Fix Cypress tests related to result type control change. | ✅ |
Possibly related PRs
- #33228: Modifications related to Bug 28287, enhancing UI interactions in the
BottomPanecomponent. - #36865: Updates to the test case for Bug 28287, focusing on response type management.
- #37410: Enhancements to the
BottomPanefor managing response types, streamlining testing processes. - #37245: Changes to open the response pane by default, ensuring expected behavior during query creation.
- #37100: Reordering response pane tabs to default to the schema tab, complementing the main PR's changes.
- #36887: Modifications to the settings button in the response pane, improving overall functionality.
- #37242: Adjustments to eliminate UI gaps, enhancing layout and component positioning.
- #37340: Updates to the function icon in the JS editor, focusing on user interface enhancements.
Suggested labels
UI Improvement, skip-changelog
Suggested reviewers
- hetunandu
- albinAppsmith
- ApekshaBhosale
"In the land of code, where tests do roam,
We standardize names, making them home.
With buttons that bind and responses that flow,
Our UI shines bright, putting on a show!
So here's to the changes, both big and small,
Together we rise, together we code, standing tall!" 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
alex-golovanov
github-actions[bot]
Description
Query response tab UI update.
Fixes #35290
Automation
/ok-to-test tags="@tag.All"
:mag: Cypress test results
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
QueryResponseTabcomponent for managing query responses in the plugin action editor.NoResponsecomponent for improved layout and messaging.Improvements
TableandActionExecutionInProgressViewcomponents.Bug Fixes
Chores